-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iam auth support #25
Conversation
Will add test(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! 🎉
I want to test it before merging, but I don't have time right now :)
I added a few comments and will test on the weekend.
Co-authored-by: James Hutchby <jameshbbb@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking great to me 👏
Co-authored-by: James Hutchby <jameshbbb@icloud.com>
hope you can merge some time soon :) |
@hanswesterbeek sorry for the delay, and thanks for the PR! 🎉 |
Will fetch an IAM auth token optionally.
Assumes that the pg instance lives in the same region as the destination S3 bucket.
Please forgive my rusty JS. It's been a while.